Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesrefactor(Modal): Simplify disabling of FocusTrap #2862
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
PatternFly-React preview: https://patternfly-react-pr-2862.surge.sh |
| {modalBox} | ||
| </FocusTrap> | ||
| )} | ||
| <FocusTrap active={!disableFocusTrap} focusTrapOptions={{ clickOutsideDeactivates: true }} className={css(styles.bullseye)}> |
This comment has been minimized.
This comment has been minimized.
|
Can you please link the corresponding issue? |
This comment has been minimized.
This comment has been minimized.
|
@tlabaj there's no corresponding issue. I was looking at a different component that uses FocusTrap and just wanted to clean the code up for Modal |
|
Nice fix! |
|
lgtm! |
This comment has been minimized.
This comment has been minimized.
|
Looks great @SpyTec! We do require a corresponding issue to be linked before we merge a PR. I would be happy to open one for you if you would like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SpyTec commentedSep 6, 2019
•
edited by tlabaj
What: This removes complexity and uses FocusTrapReact's
activeprop instead of switching to Bullseye componentAdditional issues: #2966