Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Modal): Simplify disabling of FocusTrap #2862

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@SpyTec
Copy link
Contributor

SpyTec commented Sep 6, 2019

What: This removes complexity and uses FocusTrapReact's active prop instead of switching to Bullseye component

Additional issues: #2966

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 6, 2019

PatternFly-React preview: https://patternfly-react-pr-2862.surge.sh

{modalBox}
</FocusTrap>
)}
<FocusTrap active={!disableFocusTrap} focusTrapOptions={{ clickOutsideDeactivates: true }} className={css(styles.bullseye)}>

This comment has been minimized.

Copy link
@redallen
@tlabaj tlabaj added the css review label Sep 9, 2019
@tlabaj tlabaj added the PF4 label Sep 9, 2019
@tlabaj tlabaj requested a review from mcoker Sep 9, 2019
Copy link
Contributor

tlabaj left a comment

Can you please link the corresponding issue?

@SpyTec

This comment has been minimized.

Copy link
Contributor Author

SpyTec commented Sep 9, 2019

@tlabaj there's no corresponding issue. I was looking at a different component that uses FocusTrap and just wanted to clean the code up for Modal

Copy link
Contributor

jenny-s51 left a comment

Nice fix!

@mcoker
mcoker approved these changes Sep 17, 2019
Copy link
Contributor

mcoker left a comment

lgtm!

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Sep 18, 2019

Looks great @SpyTec! We do require a corresponding issue to be linked before we merge a PR. I would be happy to open one for you if you would like.

@tlabaj tlabaj merged commit 2ca0bec into patternfly:master Sep 19, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.