Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormGroup): Add className to element if not inline #2864

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@SpyTec
Copy link
Contributor

SpyTec commented Sep 6, 2019

What: This fixes a regression from the conversion to TypeScript. The className prop is now correctly added to the root element

Regressed line: https://github.com/patternfly/patternfly-react/pull/1933/files#diff-f425f61f010b4c0b3170c953c332aba4L56

Additional issues: fixes #2855

cc @keithjgrant

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 6, 2019

PatternFly-React preview: https://patternfly-react-pr-2864.surge.sh

Copy link
Contributor

redallen left a comment

Nice catch!

@tlabaj
tlabaj approved these changes Sep 10, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 5368124 into patternfly:master Sep 10, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.