Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chipgroup): allow chipgroup toolbar item to handle single chip #2882

Merged
merged 2 commits into from Sep 17, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Sep 6, 2019

Fixes #2866

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 6, 2019

PatternFly-React preview: https://patternfly-react-pr-2882.surge.sh

@karelhala

This comment has been minimized.

Copy link
Contributor

karelhala commented Sep 10, 2019

Codewise looks good, but visualy it looks kinda off.
Screenshot from 2019-09-10 15-22-13

@jessiehuff

This comment has been minimized.

Copy link
Contributor Author

jessiehuff commented Sep 12, 2019

@karelhala Nice catch!! :) I think I fixed it.

Copy link
Contributor

karelhala left a comment

Yeah! Looks much better.

@tlabaj
tlabaj approved these changes Sep 13, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

Copy link
Contributor

tlabaj left a comment

LGTM

@jessiehuff jessiehuff dismissed stale reviews from tlabaj, kmcfaul, and karelhala via 16eb096 Sep 17, 2019
@jessiehuff jessiehuff force-pushed the jessiehuff:fix/chipgroupToolbarItem branch from da41cdb to 16eb096 Sep 17, 2019
@tlabaj tlabaj self-assigned this Sep 17, 2019
@tlabaj
tlabaj approved these changes Sep 17, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 3d9881f into patternfly:master Sep 17, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 17, 2019

Your changes have been released in:

  • @patternfly/react-core@3.104.4
  • @patternfly/react-docs@4.13.6
  • @patternfly/react-inline-edit-extension@2.11.40
  • demo-app-ts@3.0.3
  • @patternfly/react-table@2.20.20
  • @patternfly/react-topology@2.8.38
  • @patternfly/react-virtualized-extension@1.2.28

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.