Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update Victory to 30.0.0 #2883
Victory just released a much anticipated, major update. This should help solve many of the issues folks have been noting with tooltips in #2541. For example, the new
Unfortunately, this is not a trivial bump of the Victory package number. Victory introduced breaking changes that directly affect our chart components.
In order to use the
These properties were introduced to help make space to render components such as legends, but this can also be done via
The changes in this PR also include new Victory component properties, updates to the demo app, and documentation.
The following are unused, internal only props, documented as not to be set manually. They were used internally to position donut utilization within donut threshold.
The only thing we can do about that is provide more padding to accommodate the tooltip.
By default, pie / donut charts only have 8px of padding, while area, bar, etc. have 50px. Thinking we should adjust the default padding from 8 to 20 -- 50px would make the donut too small IMO.
TheRealJon left a comment
Mostly nits. There are a lot of places where the code could be more succinct. I'm not sure what this repos best practice is for things like ES6 arrow function shorthand (
I added a commit so we get a major version bump for the package. Ignore the failing CI, it fails for the right reason!
I expect it will only do a major release for
➜ patternfly-react git:(2786-victory-update) yarn run lerna updated yarn run v1.16.0 $ /home/redallen/src/patternfly-react/node_modules/.bin/lerna updated lerna notice cli v3.14.1 lerna info versioning independent lerna info Looking for changed packages since @firstname.lastname@example.org @patternfly/react-charts lerna success found 1 package ready to publish Done in 1.75s.
It should still release fine:
Merging now and will watch the release process.