Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd line border to ChartArea and move sparkline #2887
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
PatternFly-React preview: https://patternfly-react-pr-2887.surge.sh |
|
Looks good to me |
|
Still looks good |
mceledonia left a comment
|
Looking good! |
This comment has been minimized.
This comment has been minimized.
|
Your changes have been released in:
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dlabrecq commentedSep 9, 2019
•
edited
This adds a line border to area charts and moves Sparkline to its own example, per design's request. Reviewed line border changes with @mceledonia
Fixes #2843
Area Charts
Sparkline Charts
