Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line border to ChartArea and move sparkline #2887

Merged
merged 3 commits into from Sep 13, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Sep 9, 2019

This adds a line border to area charts and moves Sparkline to its own example, per design's request. Reviewed line border changes with @mceledonia

Fixes #2843

Area Charts
Screen Shot 2019-09-09 at 11 53 28 AM

Sparkline Charts
Screen Shot 2019-09-09 at 11 47 38 AM

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 9, 2019

PatternFly-React preview: https://patternfly-react-pr-2887.surge.sh

@tlabaj tlabaj requested a review from mcarrano Sep 10, 2019
@tlabaj tlabaj added the ux review label Sep 10, 2019
Copy link
Member

mcarrano left a comment

Looks good to me

@mcarrano mcarrano added ux approved and removed ux review labels Sep 11, 2019
@dlabrecq dlabrecq requested review from mcarrano and mceledonia Sep 11, 2019
Copy link
Member

mcarrano left a comment

Still looks good

Copy link

mceledonia left a comment

Looking good!

@dlabrecq dlabrecq force-pushed the dlabrecq:2843-sparkline branch from bab5c35 to 29eaaf3 Sep 13, 2019
@redallen redallen merged commit 6229e45 into patternfly:master Sep 13, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 13, 2019

Your changes have been released in:

  • @patternfly/react-charts@4.9.12

Thanks for your contribution! 🎉

@dlabrecq dlabrecq deleted the dlabrecq:2843-sparkline branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.