Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump PF3 deps #2895

Merged
merged 11 commits into from Sep 25, 2019
Merged

Conversation

@redallen
Copy link
Contributor

redallen commented Sep 9, 2019

What: Bump our version of PF3 core. Bump version of Storybook and fix its webpack config. Use a consistent version of lodash that's up to date. Closes #2889. Closes #2906.

Additional issues: The security tab of Github (and the workings of npm audit) is complicated. Outstanding vulnerabilities actually exported to our static sites should all be closed as a part of this PR.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 12, 2019

PatternFly-React preview: https://patternfly-react-pr-2895.surge.sh

Copy link
Contributor

dlabaj left a comment

Few comments, other then that it looks good.

"start:pf4": "yarn build:pf4 && lerna run develop --parallel --stream",
"storybook:openurl": "node ./storybook/openBrowser.js",

This comment has been minimized.

Copy link
@dlabaj

dlabaj Sep 17, 2019

Contributor

Is this not needed anymore?

This comment has been minimized.

Copy link
@redallen

redallen Sep 17, 2019

Author Contributor

Nope, the new storybook opens by itself and prints a message to the console with the link.

'patternfly-react': path.resolve(__dirname, '../packages/patternfly-3/patternfly-react/src')
};

return defaultConfig;
console.log('config', config.module.rules)

This comment has been minimized.

Copy link
@dlabaj

dlabaj Sep 17, 2019

Contributor

Do we need to log this ... can it be removed.

This comment has been minimized.

Copy link
@redallen

redallen Sep 17, 2019

Author Contributor

Good catch, thanks.

@tlabaj tlabaj requested a review from jschuler Sep 17, 2019
@tlabaj tlabaj added the chore 🏠 label Sep 17, 2019
@redallen redallen force-pushed the redallen:chore/security-deps branch 5 times, most recently from 82e0628 to 3c9f1e6 Sep 17, 2019
@dlabaj

This comment has been minimized.

Copy link
Contributor

dlabaj commented Sep 23, 2019

@redallen Looks like the build is failing.

@redallen redallen force-pushed the redallen:chore/security-deps branch from d7ba84f to 0ad4e8d Sep 24, 2019
Copy link
Contributor

jcaianirh left a comment

lgtm

@redallen redallen dismissed stale reviews from jcaianirh and dlabaj via 74b6ac2 Sep 24, 2019
@redallen

This comment has been minimized.

Copy link
Contributor Author

redallen commented Sep 24, 2019

@dlabaj @tlabaj Can we get this in before we merge anything else? Any change will cause conflicts.

@dlabaj
dlabaj approved these changes Sep 24, 2019
@jeff-phillips-18 jeff-phillips-18 merged commit 8995b2b into patternfly:master Sep 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 25, 2019

Your changes have been released in:

  • patternfly-react-extensions@2.20.7
  • patternfly-react-wooden-tree@2.0.4
  • patternfly-react@2.39.2
  • @patternfly/react-console@1.12.11
  • @patternfly/react-charts@5.0.11
  • @patternfly/react-core@3.105.2
  • @patternfly/react-docs@4.13.17
  • @patternfly/react-inline-edit-extension@2.11.53
  • demo-app-ts@3.2.2
  • @patternfly/react-integration@3.2.1
  • @patternfly/react-styled-system@3.6.38
  • @patternfly/react-table@2.22.2
  • @patternfly/react-topology@2.8.49
  • @patternfly/react-virtualized-extension@1.2.39

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.