Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(stacked area chart): adds demo and test #2896

Merged
merged 3 commits into from Sep 11, 2019

Conversation

@jenny-s51
Copy link
Contributor

jenny-s51 commented Sep 9, 2019

Closes #2853

@jenny-s51 jenny-s51 requested a review from dlabrecq Sep 9, 2019
@@ -225,6 +228,7 @@ class MultiColorChart extends React.Component {
```

## Sparkline chart

This comment has been minimized.

Copy link
@dlabrecq

dlabrecq Sep 9, 2019

Member

Can you please remove the extra lines? I've made changes to this file, over multiple open PRs, and wish to avoid merge conflicts

This comment has been minimized.

Copy link
@jenny-s51

jenny-s51 Sep 10, 2019

Author Contributor

sure, I'll remove them! sorry -- added those to resolve the linting errors I was getting

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 9, 2019

PatternFly-React preview: https://patternfly-react-pr-2896.surge.sh

@jenny-s51 jenny-s51 requested a review from redallen Sep 11, 2019
Copy link
Contributor

redallen left a comment

Always thankful for more tests. Thanks Jenny!

@redallen redallen merged commit 426da57 into patternfly:master Sep 11, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.