Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live edit caret color so it is visible #2899

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@TheRealJon
Copy link
Contributor

TheRealJon commented Sep 10, 2019

What:

Live editor caret was invisible since it was the same color as the background. Changed to white so that it is visible against the black background.

screencast-localhost-8000-2019 09 10-12-01-42

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 10, 2019

PatternFly-React preview: https://patternfly-react-pr-2899.surge.sh

@TheRealJon TheRealJon requested review from dgutride and redallen Sep 10, 2019
Copy link
Contributor

redallen left a comment

One line that will save every dev's life.

@TheRealJon

This comment has been minimized.

Copy link
Contributor Author

TheRealJon commented Sep 10, 2019

@redallen @jschuler Who wants to press the big green button?

@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Sep 10, 2019

The repo is frozen now, but we'll click it real soon :)

@redallen redallen merged commit 1a6d7b5 into patternfly:master Sep 13, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 13, 2019

Your changes have been released in:

  • @patternfly/react-charts@4.9.11
  • @patternfly/react-docs@4.13.1
  • demo-app-ts@2.24.9
  • @patternfly/react-integration@2.24.1

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.