Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(copyclipboard): add prop for expanded by default #2923

Merged
merged 6 commits into from Sep 19, 2019

Conversation

@christiemolloy
Copy link
Member

christiemolloy commented Sep 13, 2019

closes #2886

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 13, 2019

PatternFly-React preview: https://patternfly-react-pr-2923.surge.sh

Copy link
Contributor

jenny-s51 left a comment

LGTM 🙂

Copy link
Contributor

tlabaj left a comment

Can you also update the integration up so it use this prop and update the cypress test.

@@ -44,6 +44,8 @@ export interface ClipboardCopyProps extends Omit<React.HTMLProps<HTMLDivElement>
toggleAriaLabel?: string;
/** Flag to show if the input is read only. */
isReadOnly?: boolean;
/** Flag to determine if clipboard copy is in the expanded state initially */
isExpanded?: boolean;

This comment has been minimized.

Copy link
@tlabaj

tlabaj Sep 17, 2019

Contributor

you need to add a default for this prop in 'defaultProps`

@tlabaj tlabaj self-assigned this Sep 17, 2019
@dlabaj
dlabaj approved these changes Sep 18, 2019
@boaz0
boaz0 approved these changes Sep 18, 2019
@tlabaj
tlabaj approved these changes Sep 19, 2019
Copy link
Contributor

tlabaj left a comment

Looks great!

@tlabaj tlabaj merged commit 8cd5d13 into patternfly:master Sep 19, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 19, 2019

Your changes have been released in:

  • @patternfly/react-core@3.104.7
  • @patternfly/react-docs@4.13.9
  • @patternfly/react-inline-edit-extension@2.11.43
  • demo-app-ts@3.0.6
  • @patternfly/react-integration@3.0.1
  • @patternfly/react-table@2.20.23
  • @patternfly/react-topology@2.8.41
  • @patternfly/react-virtualized-extension@1.2.31

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.