Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): add flag to hide select all #2926

Merged
merged 5 commits into from Sep 20, 2019

Conversation

@kmcfaul
Copy link
Contributor

kmcfaul commented Sep 13, 2019

What:

Additional issues: #2876

@kmcfaul kmcfaul requested a review from priley86 Sep 13, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 13, 2019

PatternFly-React preview: https://patternfly-react-pr-2926.surge.sh

Copy link
Contributor

karelhala left a comment

Looking good. Easy and straight forward solution.

Copy link
Contributor

tlabaj left a comment

Can you add a demo to the integration app for this.

Copy link
Contributor

jessiehuff left a comment

LGTM :)

@kmcfaul kmcfaul dismissed stale reviews from jessiehuff, priley86, and karelhala via 36e98ea Sep 20, 2019
@kmcfaul kmcfaul force-pushed the kmcfaul:table-select-all-toggle branch from 36e98ea to 868af7a Sep 20, 2019
@redallen redallen dismissed tlabaj’s stale review Sep 20, 2019

Test has been added.

@redallen redallen merged commit 419b6ff into patternfly:master Sep 20, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 20, 2019

Your changes have been released in:

  • @patternfly/react-inline-edit-extension@2.11.49
  • demo-app-ts@3.1.0
  • @patternfly/react-integration@3.1.0
  • @patternfly/react-table@2.21.0

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.