Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tables): support height auto modifier in tr #2932

Merged
merged 1 commit into from Sep 23, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Sep 16, 2019

What:

closes #2930

//cc @mcoker @dlabrecq

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 16, 2019

PatternFly-React preview: https://patternfly-react-pr-2932.surge.sh

Copy link
Member

dlabrecq left a comment

Looks good. Although, do we want to bump the patternfly version manually? The build automatically bumps the version numbers whenever there is a release -- typically that has been done separately.

Just need to fix the tests

@mcoker

This comment has been minimized.

Copy link
Contributor

mcoker commented Sep 16, 2019

How do you use cellHeightAuto? And can we document that in the table component?

@tlabaj tlabaj requested a review from priley86 Sep 17, 2019
@priley86

This comment has been minimized.

Copy link
Member

priley86 commented Sep 17, 2019

yea, PF upgrades are typically done in separate PRs... but this looks fine to me 👍

cc'ing: @redallen

@priley86 priley86 requested a review from seanforyou23 Sep 17, 2019
Copy link
Contributor

karelhala left a comment

Looking good. We should def think about a way how to document all these decorators and transformers. I guess a list with some kind of description where to use it cpulf be enough. If this description could be pulled from comments that would be even more awesome.

Copy link
Contributor

tlabaj left a comment

the patternfly core version has been updated. You can remove the manual version bumps from your code.

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@boaz0 boaz0 dismissed stale reviews from karelhala and dlabrecq via 1145467 Sep 20, 2019
@boaz0 boaz0 force-pushed the boaz0:closes_2930 branch from 001b319 to 1145467 Sep 20, 2019
@tlabaj
tlabaj approved these changes Sep 23, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit b2974b6 into patternfly:master Sep 23, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 23, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.0.7
  • @patternfly/react-core@3.105.0
  • @patternfly/react-docs@4.13.15
  • @patternfly/react-inline-edit-extension@2.11.51
  • demo-app-ts@3.2.0
  • @patternfly/react-integration@3.2.0
  • @patternfly/react-table@2.22.0
  • @patternfly/react-topology@2.8.47
  • @patternfly/react-virtualized-extension@1.2.37

Thanks for your contribution! 🎉

@boaz0

This comment has been minimized.

Copy link
Member Author

boaz0 commented Sep 24, 2019

Thank you @tlabaj & @dlabrecq

@boaz0 boaz0 deleted the boaz0:closes_2930 branch Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.