Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cards): refactor sub-component references #2935

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@sjd78
Copy link
Member

sjd78 commented Sep 16, 2019

Due to #2931, rearrange the way Card includes the component's sub-components to match the way the Wizard (and all other components) does it. The new style will allow the sub-component references to survive webpack tree shaking.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 16, 2019

PatternFly-React preview: https://patternfly-react-pr-2935.surge.sh

@tlabaj tlabaj requested review from kmcfaul and jeff-phillips-18 Sep 17, 2019
@tlabaj tlabaj added the PF3 label Sep 17, 2019
@kmcfaul

This comment has been minimized.

Copy link
Contributor

kmcfaul commented Sep 23, 2019

Looks like tests may have to be updated, otherwise looks good

Copy link
Member

dlabrecq left a comment

LGTM -- please fix tests

Due to #2931, rearrange the way `Card`
includes the component's sub-components to match the way the
`Wizard` (and all other components) does it.  The new style will
allow the subcomponent references to survive webpack tree shaking.
@sjd78 sjd78 dismissed stale reviews from dlabrecq and jeff-phillips-18 via 465cac2 Oct 16, 2019
@sjd78 sjd78 force-pushed the sjd78:pf3-card-tree-shaking branch from 0507ca0 to 465cac2 Oct 16, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #2935 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2935      +/-   ##
==========================================
+ Coverage   68.94%   68.98%   +0.04%     
==========================================
  Files         858      858              
  Lines       23590    23612      +22     
  Branches     1887     1887              
==========================================
+ Hits        16263    16288      +25     
+ Misses       6367     6364       -3     
  Partials      960      960
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.3% <100%> (+0.07%) ⬆️
#patternfly4 67.93% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...y-3/patternfly-react/src/components/Cards/index.js 100% <100%> (ø) ⬆️
...ly-3/patternfly-react/src/components/Cards/Card.js 89.33% <100%> (+28.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031b8f7...465cac2. Read the comment docs.

@sjd78 sjd78 requested a review from dlabrecq Oct 16, 2019
@dlabrecq dlabrecq merged commit 17a51ff into patternfly:master Oct 16, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@sjd78 sjd78 deleted the sjd78:pf3-card-tree-shaking branch Oct 16, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 16, 2019

Your changes have been released in:

  • patternfly-react-extensions@3.0.1
  • patternfly-react@2.39.5
  • @patternfly/react-console@2.0.1

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.