Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): add max height property, update tests #2946

Merged
merged 4 commits into from Sep 25, 2019

Conversation

@kmcfaul
Copy link
Contributor

kmcfaul commented Sep 17, 2019

What: adds a maximum height property to select menu

Refer to issue: #2483

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 17, 2019

PatternFly-React preview: https://patternfly-react-pr-2946.surge.sh

Copy link
Contributor

tlabaj left a comment

Can you had a demo in the integration app with this prop.

@kmcfaul kmcfaul force-pushed the kmcfaul:select-max-height branch from a215e0b to f6da4fc Sep 23, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@kmcfaul kmcfaul force-pushed the kmcfaul:select-max-height branch from f6da4fc to 2b74717 Sep 25, 2019
@kmcfaul kmcfaul force-pushed the kmcfaul:select-max-height branch from 2b74717 to 52fa00c Sep 25, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #2946 into master will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2946      +/-   ##
==========================================
- Coverage   68.94%   68.94%   -0.01%     
==========================================
  Files         849      849              
  Lines       23214    23220       +6     
  Branches     1768     1771       +3     
==========================================
+ Hits        16006    16008       +2     
- Misses       6325     6327       +2     
- Partials      883      885       +2
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.16% <ø> (ø) ⬆️
#patternfly4 67.99% <40%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Select/Select.tsx 63.33% <100%> (+0.2%) ⬆️
...-4/react-core/src/components/Select/SelectMenu.tsx 81.03% <25%> (-4.16%) ⬇️
...y-react-extensions/src/components/Select/Select.js 19.59% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7dd72...52fa00c. Read the comment docs.

@tlabaj
tlabaj approved these changes Sep 25, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit af0ea5f into patternfly:master Sep 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 25, 2019

Your changes have been released in:

  • @patternfly/react-core@3.107.0
  • @patternfly/react-docs@4.13.21
  • @patternfly/react-inline-edit-extension@2.11.57
  • demo-app-ts@3.4.0
  • @patternfly/react-integration@3.4.0
  • @patternfly/react-table@2.22.6
  • @patternfly/react-topology@2.8.53
  • @patternfly/react-virtualized-extension@1.2.43

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.