Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(charts): update chart tutorial paths #2962

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Sep 19, 2019

Renamed the chart tutorials to be more readable. As a result, paths to the chart tutorials must be updated.

Fixes #2961

Fixes #2961
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 19, 2019

PatternFly-React preview: https://patternfly-react-pr-2962.surge.sh

@tlabaj
tlabaj approved these changes Sep 19, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

Copy link
Contributor

jenny-s51 left a comment

It seems like the comment I added might need to be addressed outside the scope of this issue -- otherwise the paths look good 🙂

@@ -20,7 +20,7 @@ In this tutorial, we will build a bar chart together - starting with a simple ch
a legend, and concluding by changing the theme color. You'll learn how to use React chart components together to build
a consistent user experience.

[Start course](https://katacoda.com/patternfly/courses/charts/module-donut)
[Start course](https://katacoda.com/patternfly/courses/charts/donut-chart)

This comment has been minimized.

Copy link
@jenny-s51

jenny-s51 Sep 19, 2019

Contributor

When I follow this link, the title for the course is "intro to donut utilization chart components" rather than "donut chart components", but I think it needs to be the latter

Screen Shot 2019-09-19 at 4 25 32 PM

This comment has been minimized.

Copy link
@dlabrecq

dlabrecq Sep 19, 2019

Author Member

Ah, that's a typo in the Katacoda tutorial. I'll have to fix that in another repo. Thanks!

This comment has been minimized.

Copy link
@dlabrecq

dlabrecq Sep 19, 2019

Author Member

Fixed in Katacoda

@tlabaj tlabaj merged commit 96cac5b into patternfly:master Sep 19, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 19, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.0.3

Thanks for your contribution! 🎉

@dlabrecq dlabrecq deleted the dlabrecq:2961-tutorial-update branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.