Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upchore(charts): update chart tutorial paths #2962
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
PatternFly-React preview: https://patternfly-react-pr-2962.surge.sh |
|
LGTM |
|
It seems like the comment I added might need to be addressed outside the scope of this issue -- otherwise the paths look good |
| @@ -20,7 +20,7 @@ In this tutorial, we will build a bar chart together - starting with a simple ch | |||
| a legend, and concluding by changing the theme color. You'll learn how to use React chart components together to build | |||
| a consistent user experience. | |||
|
|
|||
| [Start course](https://katacoda.com/patternfly/courses/charts/module-donut) | |||
| [Start course](https://katacoda.com/patternfly/courses/charts/donut-chart) | |||
This comment has been minimized.
This comment has been minimized.
jenny-s51
Sep 19, 2019
Contributor
When I follow this link, the title for the course is "intro to donut utilization chart components" rather than "donut chart components", but I think it needs to be the latter
This comment has been minimized.
This comment has been minimized.
dlabrecq
Sep 19, 2019
Author
Member
Ah, that's a typo in the Katacoda tutorial. I'll have to fix that in another repo. Thanks!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Your changes have been released in:
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dlabrecq commentedSep 19, 2019
Renamed the chart tutorials to be more readable. As a result, paths to the chart tutorials must be updated.
Fixes #2961