Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): Added OUIA compatibility to Table component #2964

Merged
merged 3 commits into from Oct 10, 2019

Conversation

@quarckster
Copy link
Contributor

quarckster commented Sep 19, 2019

Closes #2426

What: Added OUIA props to Table component

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 19, 2019

PatternFly-React preview: https://patternfly-react-pr-2964.surge.sh

@tlabaj tlabaj requested a review from redallen Sep 20, 2019
@tlabaj tlabaj requested a review from priley86 Sep 20, 2019
Copy link
Contributor

tlabaj left a comment

This one has some merge conflicts.

@karelhala karelhala added the ouia label Oct 1, 2019
@quarckster quarckster dismissed stale reviews from dlabrecq, priley86, nicolethoen, and redallen via f497d82 Oct 7, 2019
@quarckster quarckster force-pushed the quarckster:table_ouia branch from 1c503fa to f497d82 Oct 7, 2019
@quarckster quarckster force-pushed the quarckster:table_ouia branch from f497d82 to 6fd9e89 Oct 9, 2019
@quarckster quarckster force-pushed the quarckster:table_ouia branch from 6fd9e89 to a44da5b Oct 9, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #2964 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
+ Coverage   69.02%   69.02%   +<.01%     
==========================================
  Files         858      858              
  Lines       23432    23447      +15     
  Branches     1859     1863       +4     
==========================================
+ Hits        16174    16185      +11     
- Misses       6337     6339       +2     
- Partials      921      923       +2
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.1% <75%> (ø) ⬆️
Impacted Files Coverage Δ
...rnfly-4/react-table/src/components/Table/Table.tsx 91.25% <75%> (-2%) ⬇️
...-4/react-table/src/components/Table/RowWrapper.tsx 77.55% <75%> (-1.52%) ⬇️
...y-3/patternfly-react/src/components/Table/Table.js 95.71% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7313d...2e4eef5. Read the comment docs.

@quarckster quarckster force-pushed the quarckster:table_ouia branch from 7afdc29 to 2e4eef5 Oct 9, 2019
@quarckster

This comment has been minimized.

Copy link
Contributor Author

quarckster commented Oct 9, 2019

@redallen tests passed

@tlabaj
tlabaj approved these changes Oct 10, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 2a17e77 into patternfly:master Oct 10, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@quarckster quarckster deleted the quarckster:table_ouia branch Oct 10, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 10, 2019

Your changes have been released in:

  • @patternfly/react-inline-edit-extension@2.11.84
  • @patternfly/react-table@2.23.0

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.