Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-table): fix cell title warning #2967

Merged
merged 1 commit into from Sep 20, 2019

Conversation

@priley86
Copy link
Member

priley86 commented Sep 19, 2019

What:
fix the warning in #2941 - the title prop should allow JSX too.

Additional issues:

Copy link
Contributor

AllenBW left a comment

😍 😍 😍 😍 😍 😍 😍

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 19, 2019

PatternFly-React preview: https://patternfly-react-pr-2967.surge.sh

@tlabaj
tlabaj approved these changes Sep 19, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj self-assigned this Sep 19, 2019
@redallen redallen merged commit e7c39b7 into patternfly:master Sep 20, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 20, 2019

Your changes have been released in:

  • @patternfly/react-inline-edit-extension@2.11.50
  • @patternfly/react-table@2.21.1

Thanks for your contribution! 🎉

AllenBW added a commit to AllenBW/insights-advisor-frontend that referenced this pull request Sep 23, 2019
AllenBW added a commit to RedHatInsights/insights-advisor-frontend that referenced this pull request Sep 23, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Sep 23, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Sep 23, 2019
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.