Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(modal): change the cancel button variant to link #2979

Merged
merged 1 commit into from Sep 25, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Sep 20, 2019

What:
closes #2585

Update Modal document to have cancel button as link.

@jschuler is that what you meant?

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 20, 2019

PatternFly-React preview: https://patternfly-react-pr-2979.surge.sh

@jenny-s51 jenny-s51 self-assigned this Sep 20, 2019
@jenny-s51 jenny-s51 requested review from jenny-s51 and jschuler Sep 20, 2019
Copy link
Contributor

jenny-s51 left a comment

LGTM, waiting for @jschuler to confirm

@mcarrano

This comment has been minimized.

Copy link
Member

mcarrano commented Sep 24, 2019

Looks great. Thanks @boaz0 !

@mcarrano mcarrano added ux approved and removed ux review labels Sep 24, 2019
@tlabaj
tlabaj approved these changes Sep 25, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit b9c2068 into patternfly:master Sep 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.