Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(HorizontalNavMenuItem): Fix onItemClick PropType. #2984
Conversation
HorizontalNavMenuItem 's onItemClick should be a function not an object.
|
Good catch! |
This comment has been minimized.
This comment has been minimized.
|
PatternFly-React preview: https://patternfly-react-pr-2984.surge.sh |
martinpovolny
added a commit
to martinpovolny/react-ui-components
that referenced
this pull request
Sep 23, 2019
Fix according to @rvsia. Requires patternfly/patternfly-react#2984
|
Can you please link associated issue. Thanks! |
This comment has been minimized.
This comment has been minimized.
There's none. Do we need 6 people and an issue to merge a trivial 1 line fix to Patternfly? |
This comment has been minimized.
This comment has been minimized.
|
@martinpovolny We do need an issue for all bugs (https://github.com/patternfly/patternfly-react/blob/master/CONTRIBUTING.md#creating-issues-for-bugs). We only need 2 approvals to merge a PR. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Your changes have been released in:
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
martinpovolny commentedSep 23, 2019
•
edited
HorizontalNavMenuItem 's onItemClick should be a function not an object.
It's getting passed as
onClickto<a href ...>so it must be a bug.Issue: #2994
Ping @rvsia, @karelhala