Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Flex): Added support for flex layout, tests, etc. #2985

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Sep 23, 2019

Added React support for Flex and FlexItem. Moved Nicole's DataToolbar breakpoint utility to main utils and added tests so I could reuse it for Flex.

Fixes #2860.

Added React support for Flex and FlexItem. Moved DataToolbar's breakpoint utility to main utils and added tests.

Fixes #2860.
@rebeccaalpert rebeccaalpert added the PF4 label Sep 23, 2019
@rebeccaalpert rebeccaalpert requested a review from nicolethoen Sep 23, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 23, 2019

PatternFly-React preview: https://patternfly-react-pr-2985.surge.sh

Copy link
Contributor

nicolethoen left a comment

Looks beautiful!

Copy link
Contributor

tlabaj left a comment

Can you add a demo and integration tests for this please.

@rebeccaalpert rebeccaalpert dismissed stale reviews from kmcfaul and nicolethoen via e970878 Sep 24, 2019
@rebeccaalpert

This comment has been minimized.

Copy link
Member Author

rebeccaalpert commented Sep 24, 2019

Added demo and integration test.

Copy link
Contributor

mattnolting left a comment

It's beautiful! 🎉

@mcarrano mcarrano added ux approved and removed ux review labels Sep 25, 2019
Copy link
Member

mcarrano left a comment

Looks good to me

@tlabaj
tlabaj approved these changes Sep 25, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit bc5af59 into patternfly:master Sep 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 25, 2019

Your changes have been released in:

  • @patternfly/react-core@3.108.0
  • @patternfly/react-docs@4.13.22
  • @patternfly/react-inline-edit-extension@2.11.58
  • demo-app-ts@3.5.0
  • @patternfly/react-integration@3.5.0
  • @patternfly/react-table@2.22.7
  • @patternfly/react-topology@2.8.54
  • @patternfly/react-virtualized-extension@1.2.44

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.