Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): disabled button only applies disabled attribute #2989

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Sep 23, 2019

Fixes #2937

@jessiehuff jessiehuff changed the title Disabled button only applies disabled attribute fix(dropdown): disabled button only applies disabled attribute Sep 23, 2019
Jessie
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 23, 2019

PatternFly-React preview: https://patternfly-react-pr-2989.surge.sh

@jenny-s51 jenny-s51 self-requested a review Sep 23, 2019
@jenny-s51 jenny-s51 removed their request for review Sep 23, 2019
@tlabaj tlabaj added the css review label Sep 23, 2019
@tlabaj tlabaj requested a review from mcoker Sep 23, 2019
@mcoker
mcoker approved these changes Sep 24, 2019
Copy link
Contributor

mcoker left a comment

nice! thanks @jessiehuff!

@tlabaj tlabaj merged commit 951816f into patternfly:master Sep 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 25, 2019

Your changes have been released in:

  • @patternfly/react-core@3.105.3
  • @patternfly/react-docs@4.13.18
  • @patternfly/react-inline-edit-extension@2.11.54
  • demo-app-ts@3.2.3
  • @patternfly/react-table@2.22.3
  • @patternfly/react-topology@2.8.50
  • @patternfly/react-virtualized-extension@1.2.40

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.