Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): Add props for hard coded strings #2993

Merged
merged 1 commit into from Sep 25, 2019
Merged

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Sep 23, 2019

#2901

What:

Additional issues:

@tlabaj tlabaj requested review from dlabaj and kmcfaul Sep 23, 2019
@tlabaj tlabaj requested a review from jschuler Sep 23, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 23, 2019

PatternFly-React preview: https://patternfly-react-pr-2993.surge.sh

@dlabaj
dlabaj approved these changes Sep 25, 2019
@dlabaj dlabaj merged commit 1377c7e into patternfly:master Sep 25, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 25, 2019

Your changes have been released in:

  • @patternfly/react-core@3.105.4
  • @patternfly/react-docs@4.13.19
  • @patternfly/react-inline-edit-extension@2.11.55
  • demo-app-ts@3.2.4
  • @patternfly/react-integration@3.2.2
  • @patternfly/react-table@2.22.4
  • @patternfly/react-topology@2.8.51
  • @patternfly/react-virtualized-extension@1.2.41

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.