Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Chip): Added OUIA compatibility to Chip component #2995

Merged
merged 3 commits into from Oct 7, 2019

Conversation

@quarckster
Copy link
Contributor

quarckster commented Sep 24, 2019

What: Added OUIA props to Tabs as per #2425

Additional issues: tests failed with these errors and I cannot figure out what I should do next:

@quarckster

This comment has been minimized.

Copy link
Contributor Author

quarckster commented Sep 24, 2019

@quarckster quarckster mentioned this pull request Sep 24, 2019
8 of 9 tasks complete
@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Sep 25, 2019

Same deal as with Select in #2996 .

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 25, 2019

PatternFly-React preview: https://patternfly-react-pr-2995.surge.sh

Copy link
Contributor

tlabaj left a comment

This one has some failing snapshot test. Can you please update them.

@quarckster quarckster changed the title [WIP] feat(Chip): Added OUIA compatibility to Chip component feat(Chip): Added OUIA compatibility to Chip component Sep 27, 2019
@quarckster

This comment has been minimized.

Copy link
Contributor Author

quarckster commented Sep 27, 2019

@tlabaj fixed

@karelhala karelhala added the ouia label Oct 1, 2019
Copy link
Contributor

tlabaj left a comment

can you please resolve merge conflicts so we can merge this one. Thanks

@tlabaj tlabaj self-assigned this Oct 3, 2019
@quarckster quarckster dismissed stale reviews from redallen, dlabrecq, tlabaj, and karelhala via 3bccc6e Oct 7, 2019
@quarckster quarckster force-pushed the quarckster:chipgroup_ouia branch from eb7c88b to 3bccc6e Oct 7, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #2995 into master will increase coverage by <.01%.
The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2995      +/-   ##
==========================================
+ Coverage   69.02%   69.02%   +<.01%     
==========================================
  Files         858      858              
  Lines       23413    23430      +17     
  Branches     1853     1859       +6     
==========================================
+ Hits        16160    16172      +12     
- Misses       6333     6337       +4     
- Partials      920      921       +1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68.09% <65.21%> (ø) ⬆️
Impacted Files Coverage Δ
...fly-4/react-core/src/components/ChipGroup/Chip.tsx 78.84% <65.21%> (-4.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650c823...3bccc6e. Read the comment docs.

@redallen redallen merged commit bd358b6 into patternfly:master Oct 7, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 7, 2019

Your changes have been released in:

  • @patternfly/react-core@3.113.0
  • @patternfly/react-docs@4.14.11
  • @patternfly/react-inline-edit-extension@2.11.79
  • demo-app-ts@3.6.18
  • @patternfly/react-table@2.22.28
  • @patternfly/react-topology@2.8.73
  • @patternfly/react-virtualized-extension@1.2.63

Thanks for your contribution! 🎉

@quarckster quarckster deleted the quarckster:chipgroup_ouia branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.