Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OUIA compatibility to Select component #2996

Merged
merged 3 commits into from Oct 11, 2019

Conversation

@quarckster
Copy link
Contributor

quarckster commented Sep 24, 2019

What: Added OUIA props to Tabs as per #2423

Additional issues: tests failed:

 FAIL  packages/patternfly-4/react-core/src/components/Select/Select.test.tsx
  ● Test suite failed to run

    TypeScript diagnostics (customize using `[jest-config].globals.ts-jest.diagnostics` option):
    packages/patternfly-4/react-core/src/components/Select/Select.tsx:538:47 - error TS2345: Argument of type 'typeof Select' is not assignable to parameter of type 'ComponentClass<SelectProps & InjectedOuiaProps, any> | FunctionComponent<SelectProps & InjectedOuiaProps>'.
      Type 'typeof Select' is not assignable to type 'ComponentClass<SelectProps & InjectedOuiaProps, any>'.
        Types of property 'defaultProps' are incompatible.
          Type '{ "children": ReactElement<any, string | ((props: any) => ReactElement<any, string | ... | (new (props: any) => Component<any, any, any>)>) | (new (props: any) => Component<any, any, any>)>[]; ... 21 more ...; "onFilter": () => {}; }' is not assignable to type 'Partial<SelectProps & InjectedOuiaProps>'.
            Types of property 'onClear' are incompatible.
              Type 'Function' is not assignable to type '(event: MouseEvent<Element, MouseEvent>) => void'.
                Type 'Function' provides no match for the signature '(event: MouseEvent<Element, MouseEvent>): void'.

    538 const SelectWithOuiaContext = withOuiaContext(Select);

@redallen @jschuler @karelhala I would appreciate any help with this.

@redallen redallen force-pushed the quarckster:select_ouia branch 2 times, most recently from b60624e to a656bd0 Sep 25, 2019
@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Sep 25, 2019

This was a problem with the defaultProps' type, I pushed a change that will hopefully fix it.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 25, 2019

PatternFly-React preview: https://patternfly-react-pr-2996.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #2996 into master will decrease coverage by 0.04%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2996      +/-   ##
==========================================
- Coverage   69.02%   68.98%   -0.05%     
==========================================
  Files         858      858              
  Lines       23432    23450      +18     
  Branches     1859     1862       +3     
==========================================
+ Hits        16174    16177       +3     
- Misses       6337     6351      +14     
- Partials      921      922       +1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (-0.01%) ⬇️
#patternfly4 68% <69.23%> (-0.1%) ⬇️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Select/Select.tsx 60.93% <69.23%> (-2.4%) ⬇️
...ternfly-3/react-console/src/SerialConsole/XTerm.js 25% <0%> (-2.42%) ⬇️
...y-react-extensions/src/components/Select/Select.js 19.8% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7313d...7c4d27e. Read the comment docs.

@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Sep 25, 2019

Fixed the type used in a test.

@quarckster quarckster mentioned this pull request Sep 26, 2019
2 of 5 tasks complete
@quarckster quarckster force-pushed the quarckster:select_ouia branch from 63a2f66 to f744f60 Sep 27, 2019
@quarckster

This comment has been minimized.

Copy link
Contributor Author

quarckster commented Sep 27, 2019

@redallen I'm afraid I can't fix failed tests. These errors are so cryptic to me.

@karelhala karelhala requested review from redallen, kmcfaul and tlabaj and removed request for kmcfaul Oct 1, 2019
@karelhala karelhala added the ouia label Oct 1, 2019
@karelhala

This comment has been minimized.

Copy link
Contributor

karelhala commented Oct 1, 2019

@quarckster you gotta update snapshots in order to fix circle build, this can be done by running
node_modules/.bin/jest -u packages/patternfly-4/react-core/src/components/Select

@quarckster quarckster force-pushed the quarckster:select_ouia branch from f744f60 to 8fd807e Oct 8, 2019
@quarckster

This comment has been minimized.

Copy link
Contributor Author

quarckster commented Oct 8, 2019

@karelhala I applied your patch but there are still some errors

@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Oct 8, 2019

If you rebase on latest upstream and run yarn test:pf4 -u I think it should work.

@quarckster quarckster force-pushed the quarckster:select_ouia branch from 8fd807e to 7c4d27e Oct 9, 2019
@quarckster

This comment has been minimized.

Copy link
Contributor Author

quarckster commented Oct 9, 2019

@redallen tests passed

@tlabaj
tlabaj approved these changes Oct 10, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@redallen redallen merged commit 4920cf1 into patternfly:master Oct 11, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@quarckster quarckster deleted the quarckster:select_ouia branch Oct 11, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 11, 2019

Your changes have been released in:

  • @patternfly/react-core@3.114.1
  • @patternfly/react-docs@4.14.17
  • @patternfly/react-inline-edit-extension@2.11.86
  • demo-app-ts@3.7.1
  • @patternfly/react-table@2.23.2
  • @patternfly/react-topology@2.8.79
  • @patternfly/react-virtualized-extension@1.2.69

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.