Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-table): Disable header controls with empty table #3008

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@jcaianirh
Copy link
Contributor

jcaianirh commented Sep 25, 2019

Fixes: #1431

What: When no rows exist in the table, disable the select all checkbox if present, and disable the sortable column mouse behavior (mouse pointer, text highlight)

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 25, 2019

PatternFly-React preview: https://patternfly-react-pr-3008.surge.sh

When no rows exist in the table, disable the select all checkbox if present, and disable the
sortable column mouse behavior (mouse pointer, text highlight)

#1431
@jcaianirh jcaianirh force-pushed the jcaianirh:pf4table-header-controls branch from 7aaccdd to ffc2268 Oct 11, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #3008 into master will increase coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3008      +/-   ##
==========================================
+ Coverage   69.02%   69.03%   +<.01%     
==========================================
  Files         858      858              
  Lines       23535    23539       +4     
  Branches     1877     1879       +2     
==========================================
+ Hits        16246    16250       +4     
  Misses       6336     6336              
  Partials      953      953
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.12% <88.88%> (+0.01%) ⬆️
Impacted Files Coverage Δ
...-4/react-table/src/components/Table/SortColumn.tsx 77.77% <100%> (+1.3%) ⬆️
...src/components/Table/utils/decorators/sortable.tsx 100% <100%> (ø) ⬆️
...c/components/Table/utils/decorators/selectable.tsx 100% <100%> (ø) ⬆️
.../react-table/src/components/Table/SelectColumn.tsx 75% <100%> (+3.57%) ⬆️
...rnfly-4/react-table/src/components/Table/Table.tsx 91.35% <66.66%> (+0.1%) ⬆️
...y-3/patternfly-react/src/components/Table/Table.js 95.74% <0%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dcfb49...ffc2268. Read the comment docs.

Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj dismissed their stale review Oct 11, 2019

i need to look at this again

@dlabaj
dlabaj approved these changes Oct 11, 2019
@tlabaj
tlabaj approved these changes Oct 15, 2019
Copy link
Contributor

tlabaj left a comment

lgtm

@tlabaj tlabaj merged commit 3de4468 into patternfly:master Oct 15, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 15, 2019

Your changes have been released in:

  • @patternfly/react-inline-edit-extension@2.11.96
  • @patternfly/react-table@2.23.12

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.