Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-docs): Improve the documentation for Table component from react-table #3016

Merged
merged 1 commit into from Sep 26, 2019

Conversation

@KKoukiou
Copy link
Contributor

KKoukiou commented Sep 26, 2019

Some doc improvements for Table component properties.

Related to #2999, but not addressing most of the issues.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 26, 2019

PatternFly-React preview: https://patternfly-react-pr-3016.surge.sh

Copy link
Member

priley86 left a comment

these comments make sense to me, and will certainly help while reviewing Table!

@redallen redallen merged commit cb11b81 into patternfly:master Sep 26, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 26, 2019

Your changes have been released in:

  • @patternfly/react-core@3.111.0
  • @patternfly/react-docs@4.13.27
  • @patternfly/react-inline-edit-extension@2.11.63
  • demo-app-ts@3.6.4
  • @patternfly/react-table@2.22.12
  • @patternfly/react-topology@2.8.59
  • @patternfly/react-virtualized-extension@1.2.49

Thanks for your contribution! 🎉

@rachael-phillips rachael-phillips mentioned this pull request Oct 2, 2019
0 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.