Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Move ChartThreshold to its own example #3019

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Sep 26, 2019

Moved the ChartThreshold to its own example. This will make it easier to find the example and we could potentially add more examples later (e.g., for a bar chart).

Fixes #3014

Screen Shot 2019-09-27 at 12 05 49 AM

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 26, 2019

PatternFly-React preview: https://patternfly-react-pr-3019.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #3019 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3019   +/-   ##
=======================================
  Coverage   68.97%   68.97%           
=======================================
  Files         857      857           
  Lines       23445    23445           
  Branches     1847     1847           
=======================================
  Hits        16171    16171           
  Misses       6357     6357           
  Partials      917      917
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d7a7f...6997a5a. Read the comment docs.

@dlabrecq dlabrecq changed the title chore(charts): move ChartThreshold to its own example Charts: Move ChartThreshold to its own example Sep 27, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:3014-threshold-example branch 2 times, most recently from 31a6afc to 970bf6d Oct 1, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:3014-threshold-example branch from 970bf6d to 6997a5a Oct 2, 2019
@tlabaj
tlabaj approved these changes Oct 3, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@redallen redallen merged commit c38ca98 into patternfly:master Oct 3, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 3, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.0.16

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.