Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Add custom theme example #3023

Merged
merged 2 commits into from Oct 3, 2019
Merged

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Sep 27, 2019

Added an example showing how to create a custom theme that overrides default padding and colors. And as an alternative, an example showing how to override those same properties via the chart's style attribute.

Fixes #3015

Screen Shot 2019-10-03 at 9 38 30 AM

Screen Shot 2019-10-03 at 9 51 05 AM

@dlabrecq dlabrecq changed the title chore(charts): add custom theme example Charts: add custom theme example Sep 27, 2019
@dlabrecq dlabrecq changed the title Charts: add custom theme example Charts: Add custom theme example Sep 27, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:3015-theme-examples branch from 0b65600 to 58a7b78 Sep 27, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 27, 2019

PatternFly-React preview: https://patternfly-react-pr-3023.surge.sh

@dlabrecq dlabrecq force-pushed the dlabrecq:3015-theme-examples branch from 58a7b78 to 67f94fc Sep 27, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 27, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@71eb2b9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3023   +/-   ##
=========================================
  Coverage          ?   68.93%           
=========================================
  Files             ?      857           
  Lines             ?    23437           
  Branches          ?     1835           
=========================================
  Hits              ?    16156           
  Misses            ?     6365           
  Partials          ?      916
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.16% <ø> (?)
#patternfly4 67.98% <ø> (?)
Impacted Files Coverage Δ
...ct-charts/src/components/ChartLabel/ChartLabel.tsx 95% <ø> (ø)
...rts/src/components/ChartTheme/themes/base-theme.ts 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71eb2b9...5514796. Read the comment docs.

@dlabrecq dlabrecq force-pushed the dlabrecq:3015-theme-examples branch from 67f94fc to a0a084b Sep 27, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:3015-theme-examples branch 8 times, most recently from a1ab96d to e51fec4 Oct 1, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:3015-theme-examples branch from e51fec4 to b61871c Oct 3, 2019
@@ -247,10 +245,148 @@ class MultiColorChart extends React.Component {
}
```

<<<<<<< HEAD

This comment has been minimized.

Copy link
@redallen

redallen Oct 3, 2019

Contributor

Merge conflict inside of here.

This comment has been minimized.

Copy link
@dlabrecq

dlabrecq Oct 3, 2019

Author Member

Thanks, Zack! Fixed

Fixes #3015
@dlabrecq dlabrecq force-pushed the dlabrecq:3015-theme-examples branch from b61871c to 5514796 Oct 3, 2019
@tlabaj
tlabaj approved these changes Oct 3, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit b394a58 into patternfly:master Oct 3, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 3, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.0.18

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.