Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Fix ChartThreshold props #3024

Merged
merged 2 commits into from Oct 15, 2019
Merged

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Sep 27, 2019

Addressed the following issues with the new ChartThreshold component, which prevents users from providing custom dashed line colors via the style property.

  1. When users specify a themeColor, it rarely matches the color provided to a custom ChartLegend.
  2. ChartThreshold does not allow users to provide styles. The style property is destructured, but never used.
  3. Users cannot provide their own theme. ChartThreshold overrides the theme property, only applying the default threshold theme. This also prevents a theme from being inherited from a parent component.
  4. No property docs are generated for ChartThreshold because properties are extended from ChartLineProps.

Fixes #3022

Screen Shot 2019-09-26 at 11 57 08 PM

Depends on #3019 -- Will rebase when that is merged

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 27, 2019

PatternFly-React preview: https://patternfly-react-pr-3024.surge.sh

@dlabrecq dlabrecq force-pushed the dlabrecq:3022-threshold-props branch from fdd1153 to 25062eb Sep 27, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 27, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@71eb2b9). Click here to learn what that means.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3024   +/-   ##
=========================================
  Coverage          ?   68.95%           
=========================================
  Files             ?      857           
  Lines             ?    23454           
  Branches          ?     1852           
=========================================
  Hits              ?    16173           
  Misses            ?     6359           
  Partials          ?      922
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.22% <ø> (?)
#patternfly4 67.96% <57.14%> (?)
Impacted Files Coverage Δ
...s/src/components/ChartThreshold/ChartThreshold.tsx 66.66% <55.55%> (ø)
...ct-charts/src/components/ChartUtils/chart-theme.ts 65.95% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71eb2b9...d194a1b. Read the comment docs.

@dlabrecq dlabrecq force-pushed the dlabrecq:3022-threshold-props branch 2 times, most recently from 9e7124e to 2db756c Oct 1, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:3022-threshold-props branch from 2db756c to d194a1b Oct 3, 2019
@tlabaj
tlabaj approved these changes Oct 15, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 42148e1 into patternfly:master Oct 15, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 15, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.0.27

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.