Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Tabs): move TabButton to new file #3033

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Sep 27, 2019

…rate component

#3032

What:

Additional issues:

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #3033 into master will increase coverage by 0.04%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3033      +/-   ##
==========================================
+ Coverage   68.97%   69.01%   +0.04%     
==========================================
  Files         857      858       +1     
  Lines       23445    23402      -43     
  Branches     1847     1848       +1     
==========================================
- Hits        16171    16151      -20     
+ Misses       6357     6333      -24     
- Partials      917      918       +1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68.07% <94.44%> (+0.07%) ⬆️
Impacted Files Coverage Δ
...atternfly-4/react-core/src/components/Tabs/Tab.tsx 66.66% <100%> (-28.08%) ⬇️
...tternfly-4/react-core/src/components/Tabs/Tabs.tsx 69.35% <100%> (ø) ⬆️
...fly-4/react-core/src/components/Tabs/TabButton.tsx 93.75% <93.75%> (ø)
...fly-3/patternfly-react/src/components/Tabs/Tabs.js 32.87% <0%> (ø) ⬆️
...nfly-3/patternfly-react/src/components/Tabs/Tab.js 88.88% <0%> (+36.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c862f...bbfc245. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 27, 2019

PatternFly-React preview: https://patternfly-react-pr-3033.surge.sh

@tlabaj tlabaj added the Do Not Merge label Sep 30, 2019
Copy link
Member

dlabrecq left a comment

I built and tested the tab changes in Cost Management. I didn't encounter any issues and no warning messages in the browser console

@redallen

This comment has been minimized.

Copy link
Contributor

redallen commented Sep 30, 2019

There's a merge conflict now.

@tlabaj tlabaj removed the Do Not Merge label Sep 30, 2019
@tlabaj tlabaj force-pushed the tlabaj:tabsRefactor branch from bcb3620 to 85284ae Oct 2, 2019
Titani
@redallen redallen changed the title refactor(Tabs): Refactor Tabs so the Tab Button is rendered in a sepa… refactor(Tabs): move TabButton to new file Oct 3, 2019
Copy link
Contributor

redallen left a comment

Good refactor, this is what I should have written during the TS conversion. Props for the docs look good too.

@redallen redallen merged commit 74ab953 into patternfly:master Oct 3, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.