Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(switch): revert defaultChecked to checked #3037

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@redallen
Copy link
Contributor

redallen commented Sep 30, 2019

What: Closes #2997, reverts #2749

Additional issues:

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 30, 2019

PatternFly-React preview: https://patternfly-react-pr-3037.surge.sh

Copy link
Contributor

tlabaj left a comment

LGTM

@redallen redallen dismissed stale reviews from tlabaj and dlabrecq via d93e819 Oct 11, 2019
@redallen redallen force-pushed the redallen:chore/switch-revert branch from 175bc40 to d93e819 Oct 11, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #3037 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3037   +/-   ##
=======================================
  Coverage   69.03%   69.03%           
=======================================
  Files         858      858           
  Lines       23529    23529           
  Branches     1875     1875           
=======================================
  Hits        16244    16244           
  Misses       6334     6334           
  Partials      951      951
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.13% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Switch/Switch.tsx 66.66% <ø> (ø) ⬆️
...ore/src/components/Select/CheckboxSelectOption.tsx 64.44% <100%> (ø) ⬆️
.../react-core/src/components/Select/SelectOption.tsx 71.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedb42b...d93e819. Read the comment docs.

@tlabaj
tlabaj approved these changes Oct 11, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@dlabaj
dlabaj approved these changes Oct 15, 2019
@dlabaj dlabaj merged commit 329146c into patternfly:master Oct 15, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 15, 2019

Your changes have been released in:

  • @patternfly/react-core@3.116.1
  • @patternfly/react-docs@4.14.27
  • @patternfly/react-inline-edit-extension@2.11.95
  • demo-app-ts@3.7.10
  • @patternfly/react-table@2.23.11
  • @patternfly/react-topology@2.9.5
  • @patternfly/react-virtualized-extension@1.2.78

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.