Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): Adds support for custom dataLabel prop on table header #3040

Conversation

@AllenBW
Copy link
Contributor

AllenBW commented Sep 30, 2019

fixes #2941

but just in case you don't want to read the issue.... tl;dr: when collapsed table shows a very undesired column-foo when jsx is used as the table header. So lets allow for a custom data-label attribute to be passed when a dev wants to do this, so they can avoid the erum, undesired collapsed header

just in case yah wanta see what we're attempting to fix... (top is collapsed, bottom is expanded)

Screen Shot 2019-09-30 at 2 53 17 PM

Screen Shot 2019-09-30 at 2 53 30 PM

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Sep 30, 2019

PatternFly-React preview: https://patternfly-react-pr-3040.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 30, 2019

Codecov Report

Merging #3040 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3040      +/-   ##
==========================================
+ Coverage   68.97%   68.97%   +<.01%     
==========================================
  Files         857      857              
  Lines       23445    23422      -23     
  Branches     1847     1820      -27     
==========================================
- Hits        16171    16156      -15     
- Misses       6357     6365       +8     
+ Partials      917      901      -16
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.16% <ø> (-0.06%) ⬇️
#patternfly4 68.08% <50%> (+0.08%) ⬆️
Impacted Files Coverage Δ
...rnfly-4/react-table/src/components/Table/Table.tsx 93.24% <ø> (ø) ⬆️
...-4/react-table/src/components/Table/HeaderCell.tsx 73.33% <0%> (-5.24%) ⬇️
...t-table/src/components/Table/utils/headerUtils.tsx 96.29% <100%> (-0.58%) ⬇️
...table/src/components/Table/base/resolve-row-key.ts 40% <0%> (-13.85%) ⬇️
...ore/src/components/Select/CheckboxSelectOption.tsx 52.94% <0%> (-11.51%) ⬇️
...t-charts/src/components/ChartUtils/chart-origin.ts 20% <0%> (-8.58%) ⬇️
.../patternfly-3/patternfly-react/src/common/Timer.js 51.61% <0%> (-5.97%) ⬇️
...patternfly-4/react-core/src/components/Nav/Nav.tsx 71.42% <0%> (-5.17%) ⬇️
...-react/src/components/DateTimePicker/TimePicker.js 59.18% <0%> (-4.65%) ⬇️
...react/src/components/DateTimePicker/TimeHelpers.js 63.63% <0%> (-4.55%) ⬇️
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d7a7f...517ef53. Read the comment docs.

@AllenBW AllenBW force-pushed the AllenBW:enhancement/fix-table-collapse-data-label branch from 119d1ff to 517ef53 Oct 2, 2019
@AllenBW AllenBW requested a review from redallen Oct 2, 2019
@AllenBW

This comment has been minimized.

Copy link
Contributor Author

AllenBW commented Oct 2, 2019

@redallen any chance this pr can get another review from yah? we (insights app) would like to try n get this in (and use it) before this friday if possible

@tlabaj
tlabaj approved these changes Oct 3, 2019
Copy link
Contributor

tlabaj left a comment

tm

Copy link
Contributor

redallen left a comment

@AllenBW I'd say there's a chance.

@redallen redallen merged commit 79a8249 into patternfly:master Oct 3, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 3, 2019

Your changes have been released in:

  • @patternfly/react-inline-edit-extension@2.11.73
  • @patternfly/react-table@2.22.22

Thanks for your contribution! 🎉

@AllenBW AllenBW deleted the AllenBW:enhancement/fix-table-collapse-data-label branch Oct 3, 2019
@AllenBW

This comment has been minimized.

Copy link
Contributor Author

AllenBW commented Oct 3, 2019

@redallen @tlabaj ya'll rocked my thursday, thank you 🙇‍♀
Screen Shot 2019-10-03 at 9 06 58 AM
Screen Shot 2019-10-03 at 9 07 07 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.