Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Cannot wrap chart with Tippy tooltip #3048

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Oct 1, 2019

Slightly modified how chart containers are cloned and added examples. This ensures charts can be wrapped with the Tippy tooltip component as an alternate way of providing custom tooltips.

Fixes #3047

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 1, 2019

PatternFly-React preview: https://patternfly-react-pr-3048.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #3048 into master will decrease coverage by 0.04%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3048      +/-   ##
==========================================
- Coverage   68.98%   68.93%   -0.05%     
==========================================
  Files         857      857              
  Lines       23421    23437      +16     
  Branches     1819     1835      +16     
==========================================
  Hits        16156    16156              
  Misses       6365     6365              
- Partials      900      916      +16
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.16% <ø> (ø) ⬆️
#patternfly4 67.98% <20%> (-0.11%) ⬇️
Impacted Files Coverage Δ
...ChartBullet/ChartBulletComparativeErrorMeasure.tsx 74.19% <0%> (-2.48%) ⬇️
...nents/ChartBullet/ChartBulletPrimaryDotMeasure.tsx 65.85% <0%> (-3.38%) ⬇️
...onents/ChartBullet/ChartBulletQualitativeRange.tsx 56.25% <0%> (-2.45%) ⬇️
...artBullet/ChartBulletComparativeWarningMeasure.tsx 74.19% <0%> (-2.48%) ⬇️
...ChartBullet/ChartBulletPrimarySegmentedMeasure.tsx 55.1% <0%> (-2.35%) ⬇️
...-charts/src/components/ChartBullet/ChartBullet.tsx 60% <0%> (-2.59%) ⬇️
...ents/ChartBullet/ChartBulletComparativeMeasure.tsx 58.69% <0%> (-2.67%) ⬇️
...ts/ChartDonutUtilization/ChartDonutUtilization.tsx 73.49% <50%> (ø) ⬆️
...ents/ChartDonutUtilization/ChartDonutThreshold.tsx 72.72% <50%> (ø) ⬆️
.../react-charts/src/components/ChartPie/ChartPie.tsx 75.47% <50%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 259fc78...7ab0e46. Read the comment docs.

Copy link
Member

jeff-phillips-18 left a comment

LGTM, thanks Dan!

@redallen redallen merged commit 68f4311 into patternfly:master Oct 1, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 1, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.0.13

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.