Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed sentence case for component titles #3054

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@janwright73
Copy link
Contributor

janwright73 commented Oct 1, 2019

What:
fixes React items in patternfly/patternfly-org#1486; Zack is working on refactoring the HTML items in same issue.

Additional issues:
Opened React issue to track this PR: #3062

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 1, 2019

PatternFly-React preview: https://patternfly-react-pr-3054.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #3054 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3054   +/-   ##
=======================================
  Coverage   68.93%   68.93%           
=======================================
  Files         857      857           
  Lines       23437    23437           
  Branches     1835     1835           
=======================================
  Hits        16156    16156           
  Misses       6365     6365           
  Partials      916      916
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.16% <ø> (ø) ⬆️
#patternfly4 67.98% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d11315...9447427. Read the comment docs.

@janwright73 janwright73 requested review from redallen and evwilkin Oct 1, 2019
Copy link
Contributor

tlabaj left a comment

Can you please link an associated react repo issue. Let me know if you would like me to open it for you.

@janwright73

This comment has been minimized.

Copy link
Contributor Author

janwright73 commented Oct 2, 2019

Hi @tlabaj - opened #3062

@tlabaj
tlabaj approved these changes Oct 2, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 2938937 into patternfly:master Oct 2, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 2, 2019

Your changes have been released in:

  • @patternfly/react-core@3.112.5
  • @patternfly/react-docs@4.14.5
  • @patternfly/react-inline-edit-extension@2.11.72
  • demo-app-ts@3.6.12
  • @patternfly/react-table@2.22.21
  • @patternfly/react-topology@2.8.67
  • @patternfly/react-virtualized-extension@1.2.57

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.