Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loginform): pass 'remember me' state to isChecked #3056

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Oct 1, 2019

What:

closes #3051

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 1, 2019

PatternFly-React preview: https://patternfly-react-pr-3056.surge.sh

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@boaz0 boaz0 force-pushed the boaz0:closes_3051 branch from 46828f6 to 31bc15b Oct 1, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #3056 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3056   +/-   ##
=======================================
  Coverage   68.93%   68.93%           
=======================================
  Files         857      857           
  Lines       23437    23437           
  Branches     1835     1835           
=======================================
  Hits        16156    16156           
  Misses       6365     6365           
  Partials      916      916
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.16% <ø> (ø) ⬆️
#patternfly4 67.98% <ø> (ø) ⬆️
Impacted Files Coverage Δ
.../react-core/src/components/LoginPage/LoginForm.tsx 51.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af0c7aa...31bc15b. Read the comment docs.

@tlabaj
tlabaj approved these changes Oct 8, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 3d3a0ce into patternfly:master Oct 8, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 8, 2019

Your changes have been released in:

  • @patternfly/react-core@3.113.3
  • @patternfly/react-docs@4.14.14
  • @patternfly/react-inline-edit-extension@2.11.82
  • demo-app-ts@3.6.21
  • @patternfly/react-table@2.22.31
  • @patternfly/react-topology@2.8.76
  • @patternfly/react-virtualized-extension@1.2.66

Thanks for your contribution! 🎉

@boaz0 boaz0 deleted the boaz0:closes_3051 branch Oct 9, 2019
@boaz0

This comment has been minimized.

Copy link
Member Author

boaz0 commented Oct 9, 2019

🙇 Thank you @tlabaj @dlabrecq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.