Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Tooltip examples #3061

Merged
merged 1 commit into from Oct 3, 2019
Merged

Charts: Tooltip examples #3061

merged 1 commit into from Oct 3, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Oct 2, 2019

Added multiple examples of how to apply tooltips. The current examples do show tooltips, but there are several different ways they can be applied. It would be best these examples were all in one place.

  • Using data labels
  • Using a Voronoi container
  • Wrapping a chart with a Tippy tooltip
  • Adding custom tooltip component to legends
  • Using CSS overflow Vs the constrainToVisibleArea prop
  • Left aligned tooltips using a theme property

Screen Shot 2019-10-02 at 4 02 53 PM

Screen Shot 2019-10-02 at 4 03 41 PM

Screen Shot 2019-10-02 at 4 03 53 PM
#3059

@dlabrecq dlabrecq force-pushed the dlabrecq:3059-tooltips branch from c0aa1eb to 3bb5699 Oct 2, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 2, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@71eb2b9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3061   +/-   ##
=========================================
  Coverage          ?   68.93%           
=========================================
  Files             ?      857           
  Lines             ?    23437           
  Branches          ?     1835           
=========================================
  Hits              ?    16156           
  Misses            ?     6365           
  Partials          ?      916
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.16% <ø> (?)
#patternfly4 67.98% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71eb2b9...b7d13e8. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 2, 2019

PatternFly-React preview: https://patternfly-react-pr-3061.surge.sh

@dlabrecq dlabrecq force-pushed the dlabrecq:3059-tooltips branch from 3bb5699 to b7d13e8 Oct 3, 2019
@tlabaj
tlabaj approved these changes Oct 3, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 6639cf1 into patternfly:master Oct 3, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 3, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.0.17
  • @patternfly/react-core@3.112.9
  • @patternfly/react-docs@4.14.9
  • @patternfly/react-inline-edit-extension@2.11.77
  • demo-app-ts@3.6.16
  • @patternfly/react-table@2.22.26
  • @patternfly/react-topology@2.8.71
  • @patternfly/react-virtualized-extension@1.2.61

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.