Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Spinner): Fix alert type in docs #3063

Merged
merged 2 commits into from Oct 3, 2019
Merged

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Oct 2, 2019

#2986

What:

Additional issues:

Titani
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #3063 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3063   +/-   ##
=======================================
  Coverage   68.97%   68.97%           
=======================================
  Files         857      857           
  Lines       23445    23445           
  Branches     1847     1847           
=======================================
  Hits        16171    16171           
  Misses       6357     6357           
  Partials      917      917
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c862f...0f7eb6f. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 2, 2019

PatternFly-React preview: https://patternfly-react-pr-3063.surge.sh

Copy link
Contributor

evwilkin left a comment

I believe we can remove the <Alert> completely and just add this line to the frontmatter on line 7 - this is how the message has been displayed in the other Experimental components:
stage: 'early'

Titani
Copy link
Contributor

evwilkin left a comment

LGTM!

@redallen redallen merged commit 0ef3494 into patternfly:master Oct 3, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 3, 2019

Your changes have been released in:

  • @patternfly/react-core@3.112.8
  • @patternfly/react-docs@4.14.8
  • @patternfly/react-inline-edit-extension@2.11.76
  • demo-app-ts@3.6.15
  • @patternfly/react-table@2.22.25
  • @patternfly/react-topology@2.8.70
  • @patternfly/react-virtualized-extension@1.2.60

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.