Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Radio): pass checked either from isChecked or checked #3066

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@karelhala
Copy link
Contributor

karelhala commented Oct 3, 2019

Fixes: #3065

If consumer updates isChecked or chacked other than via clicking it will not propagate correctly to input, instead it will update defaultChecked. This PR fixes such issue by updating checked either from checked or isChecked.

@karelhala karelhala requested review from jschuler, dlabaj and tlabaj Oct 3, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 3, 2019

PatternFly-React preview: https://patternfly-react-pr-3066.surge.sh

@tlabaj
tlabaj approved these changes Oct 3, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 51c59fb into patternfly:master Oct 3, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.