Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Expandable): Allow for dynamic toggle text in uncontrolled version #3068

Merged

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Oct 3, 2019

Added two new props that allow user to specify collapsed and expanded toggle text for uncontrolled expandable.

Fixes #2914.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 3, 2019

PatternFly-React preview: https://patternfly-react-pr-3068.surge.sh

Copy link
Contributor

tlabaj left a comment

LGTM

@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:expandable-dynamic-uncontrolled branch from 70d7398 to cdabcb9 Oct 10, 2019
@rebeccaalpert

This comment has been minimized.

Copy link
Member Author

rebeccaalpert commented Oct 10, 2019

Adjusted variable definition in amended commit.

Added two new props that allow user to specify collapsed and expanded toggle text for uncontrolled
expandable.

Fixes #2914
@rebeccaalpert rebeccaalpert force-pushed the rebeccaalpert:expandable-dynamic-uncontrolled branch from cdabcb9 to 541e21a Oct 10, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #3068 into master will decrease coverage by 0.06%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3068      +/-   ##
==========================================
- Coverage   69.03%   68.96%   -0.07%     
==========================================
  Files         859      857       -2     
  Lines       23454    23454              
  Branches     1863     1849      -14     
==========================================
- Hits        16191    16176      -15     
- Misses       6339     6359      +20     
+ Partials      924      919       -5
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (-0.01%) ⬇️
#patternfly4 67.99% <55.55%> (-0.12%) ⬇️
Impacted Files Coverage Δ
...eact-core/src/components/Expandable/Expandable.tsx 80.95% <55.55%> (-6.93%) ⬇️
...nfly-3/patternfly-react/src/components/Tabs/Tab.js 51.92% <0%> (-36.97%) ⬇️
...ternfly-3/react-console/src/SerialConsole/XTerm.js 25% <0%> (-2.42%) ⬇️
.../react-core/src/components/Select/SelectOption.tsx 70.96% <0%> (-0.91%) ⬇️
...y-3/patternfly-react/src/components/Table/Table.js 95.62% <0%> (-0.1%) ⬇️
...tternfly-4/react-core/src/components/Tabs/Tabs.tsx 69.35% <0%> (ø) ⬆️
...y-react-extensions/src/components/Select/Select.js 19.59% <0%> (ø) ⬆️
...fly-3/patternfly-react/src/components/Tabs/Tabs.js 32.87% <0%> (ø) ⬆️
...t-table/src/components/Table/utils/headerUtils.tsx 96.87% <0%> (ø) ⬆️
...ct-charts/src/components/ChartLabel/ChartLabel.tsx 94.73% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1607e48...541e21a. Read the comment docs.

@tlabaj
tlabaj approved these changes Oct 10, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit 3c6e4b6 into patternfly:master Oct 10, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 10, 2019

Your changes have been released in:

  • @patternfly/react-core@3.114.0
  • @patternfly/react-docs@4.14.16
  • @patternfly/react-inline-edit-extension@2.11.85
  • demo-app-ts@3.7.0
  • @patternfly/react-integration@3.7.0
  • @patternfly/react-table@2.23.1
  • @patternfly/react-topology@2.8.78
  • @patternfly/react-virtualized-extension@1.2.68

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.