Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(charts): Use markdown links #3072

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Oct 4, 2019

Simply replaces HTML anchors in examples with markdown links

Fixes #3071

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 4, 2019

PatternFly-React preview: https://patternfly-react-pr-3072.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #3072 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3072      +/-   ##
==========================================
- Coverage   69.02%   69.02%   -0.01%     
==========================================
  Files         858      858              
  Lines       23432    23430       -2     
  Branches     1859     1859              
==========================================
- Hits        16174    16172       -2     
  Misses       6337     6337              
  Partials      921      921
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (-0.01%) ⬇️
#patternfly4 68.09% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ternfly-3/react-console/src/SerialConsole/XTerm.js 25% <0%> (-2.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7313d...1fcc7b4. Read the comment docs.

Copy link
Contributor

jenny-s51 left a comment

LGTM -- all links working as expected. Just need to fix what's addressed in the comment comment below 🙂

- For `ChartLegend` props, see <a href="https://formidable.com/open-source/victory/docs/victory-legend" target="_blank">VictoryLegend</a>
- For `ChartAxis` props, see [VictoryAxis](https://formidable.com/open-source/victory/docs/victory-axis)
- For `ChartBullet` props, see [VictoryBar](https://formidable.com/open-source/victory/docs/victory-bar)
- For `ChartContainer` props, see [Victory](https://formidable.com/open-source/victory/docs/victory-container)

This comment has been minimized.

Copy link
@jenny-s51

jenny-s51 Oct 5, 2019

Contributor

Did you mean to have VictoryContainer as the link text on line 877?

This comment has been minimized.

Copy link
@dlabrecq

dlabrecq Oct 7, 2019

Author Member

Good catch. Fixed. Thanks!

@dlabrecq dlabrecq force-pushed the dlabrecq:3071-markdown-links branch from 96b3768 to 185c817 Oct 7, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:3071-markdown-links branch from 185c817 to 1fcc7b4 Oct 9, 2019
@kmcfaul
kmcfaul approved these changes Oct 9, 2019
@redallen redallen merged commit fd54afa into patternfly:master Oct 9, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 9, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.0.21

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.