Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly use this.setState in components #3075

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@jessiehuff
Copy link
Contributor

jessiehuff commented Oct 4, 2019

Fixes #2822

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #3075 into master will not change coverage.
The diff coverage is 20%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3075   +/-   ##
=======================================
  Coverage   69.02%   69.02%           
=======================================
  Files         858      858           
  Lines       23413    23413           
  Branches     1853     1853           
=======================================
  Hits        16160    16160           
  Misses       6333     6333           
  Partials      920      920
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68.08% <20%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...-4/react-core/src/components/Nav/NavExpandable.tsx 65.85% <ø> (ø) ⬆️
...tternfly-4/react-core/src/components/Page/Page.tsx 82.75% <0%> (ø) ⬆️
...react-table/src/components/Table/ActionsColumn.tsx 79.16% <0%> (ø) ⬆️
...nfly-4/react-core/src/components/Select/Select.tsx 63.33% <0%> (ø) ⬆️
...eact-core/src/components/Expandable/Expandable.tsx 87.87% <100%> (ø) ⬆️
...y-react-extensions/src/components/Select/Select.js 19.59% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650c823...a3a0ab4. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 4, 2019

PatternFly-React preview: https://patternfly-react-pr-3075.surge.sh

@redallen redallen merged commit 24f319a into patternfly:master Oct 9, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 9, 2019

Your changes have been released in:

  • @patternfly/react-core@3.113.4
  • @patternfly/react-docs@4.14.15
  • @patternfly/react-inline-edit-extension@2.11.83
  • demo-app-ts@3.6.22
  • @patternfly/react-integration@3.6.3
  • @patternfly/react-table@2.22.32
  • @patternfly/react-topology@2.8.77
  • @patternfly/react-virtualized-extension@1.2.67

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.