Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesfeat(eslint): add eslint-plugin-react-hooks #3083
Merged
Conversation
* Add eslint-plugin-react-hooks so that Foreman and plugin devs will benefit from its guidance when using Hooks.
This comment has been minimized.
This comment has been minimized.
|
PatternFly-React preview: https://patternfly-react-pr-3083.surge.sh |
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Oct 7, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #3083 +/- ##
=======================================
Coverage 69.02% 69.02%
=======================================
Files 858 858
Lines 23430 23430
Branches 1859 1859
=======================================
Hits 16172 16172
Misses 6337 6337
Partials 921 921
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jeremylenz commentedOct 7, 2019
eslint-plugin-patternfly-reactso that Foreman and plugin devs will benefit from its guidance when using Hooks.This plugin checks if you're following the Rules of Hooks and is useful for anyone developing components that use React Hooks.
In Foreman we've started using Hooks, but don't yet have this rule. See this discussion with @sharvit