Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint): add eslint-plugin-react-hooks #3083

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@jeremylenz
Copy link
Contributor

jeremylenz commented Oct 7, 2019

  • Add eslint-plugin-react-hooks to eslint-plugin-patternfly-react so that Foreman and plugin devs will benefit from its guidance when using Hooks.

This plugin checks if you're following the Rules of Hooks and is useful for anyone developing components that use React Hooks.

In Foreman we've started using Hooks, but don't yet have this rule. See this discussion with @sharvit

* Add eslint-plugin-react-hooks so that Foreman and plugin devs will
benefit from its guidance when using Hooks.
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 7, 2019

PatternFly-React preview: https://patternfly-react-pr-3083.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #3083 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3083   +/-   ##
=======================================
  Coverage   69.02%   69.02%           
=======================================
  Files         858      858           
  Lines       23430    23430           
  Branches     1859     1859           
=======================================
  Hits        16172    16172           
  Misses       6337     6337           
  Partials      921      921
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68.09% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a6875...c0875de. Read the comment docs.

@tlabaj tlabaj added the Do Not Merge label Oct 9, 2019
@dlabrecq dlabrecq dismissed their stale review Oct 9, 2019

Canceling in due to team discussion

Copy link
Member

dlabrecq left a comment

Spoke with @dgutride and we agreed to bring this in

@tlabaj tlabaj removed the Do Not Merge label Oct 16, 2019
@tlabaj
tlabaj approved these changes Oct 16, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit c47f143 into patternfly:master Oct 16, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.