Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: update ChartThreshold to use pf-core variable #3085

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Oct 7, 2019

Simply updated ChartThreshold theme to use pf-core variable

Fixes #3025

Threshold chart example
Screen Shot 2019-10-07 at 4 50 05 PM

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 7, 2019

PatternFly-React preview: https://patternfly-react-pr-3085.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #3085 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3085      +/-   ##
==========================================
+ Coverage   69.02%   69.02%   +<.01%     
==========================================
  Files         858      858              
  Lines       23430    23431       +1     
  Branches     1859     1859              
==========================================
+ Hits        16172    16173       +1     
  Misses       6337     6337              
  Partials      921      921
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68.1% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...rc/components/ChartTheme/themes/threshold-theme.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293b23b...2345d76. Read the comment docs.

@kmcfaul
kmcfaul approved these changes Oct 9, 2019
@redallen redallen merged commit 3f77276 into patternfly:master Oct 9, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.