Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Add chart scatter examples #3086

Merged
merged 2 commits into from Oct 9, 2019

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Oct 7, 2019

Adds pf-core variables to the ChartScatter component and examples

Fixes #3079

Screen Shot 2019-10-07 at 5 43 03 PM

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 7, 2019

PatternFly-React preview: https://patternfly-react-pr-3086.surge.sh

@dlabrecq dlabrecq force-pushed the dlabrecq:3079-scatter-examples branch from cc0ed05 to 2f7d6d5 Oct 7, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #3086 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3086      +/-   ##
==========================================
+ Coverage   69.02%   69.02%   +<.01%     
==========================================
  Files         858      859       +1     
  Lines       23430    23436       +6     
  Branches     1859     1859              
==========================================
+ Hits        16172    16177       +5     
  Misses       6337     6337              
- Partials      921      922       +1
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (ø) ⬆️
#patternfly4 68.1% <85.71%> (ø) ⬆️
Impacted Files Coverage Δ
...ct-charts/src/components/ChartTheme/ChartStyles.ts 100% <100%> (ø) ⬆️
...src/components/ChartTheme/styles/scatter-styles.ts 100% <100%> (ø)
...harts/src/components/ChartScatter/ChartScatter.tsx 84.21% <66.66%> (-4.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 293b23b...86e092e. Read the comment docs.

@dlabrecq dlabrecq force-pushed the dlabrecq:3079-scatter-examples branch from 2f7d6d5 to c10e51b Oct 8, 2019
@dlabrecq dlabrecq force-pushed the dlabrecq:3079-scatter-examples branch from c10e51b to 86e092e Oct 8, 2019
@kmcfaul
kmcfaul approved these changes Oct 9, 2019
@redallen redallen merged commit daabae2 into patternfly:master Oct 9, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.