Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: add legend examples #3093

Merged
merged 1 commit into from Oct 9, 2019
Merged

Conversation

@dlabrecq
Copy link
Member

dlabrecq commented Oct 9, 2019

Adds examples of how to apply various legend features.

The current examples do show legends, but there are a few different ways they can be applied. It would be best these examples were all in one place.

Fixes #3080

Screen Shot 2019-10-08 at 7 55 18 PM

Screen Shot 2019-10-08 at 7 55 34 PM

Screen Shot 2019-10-08 at 9 02 52 PM

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 9, 2019

PatternFly-React preview: https://patternfly-react-pr-3093.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #3093 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3093   +/-   ##
=======================================
  Coverage   69.02%   69.02%           
=======================================
  Files         858      858           
  Lines       23432    23432           
  Branches     1859     1859           
=======================================
  Hits        16174    16174           
  Misses       6337     6337           
  Partials      921      921
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.09% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7313d...ac21e8b. Read the comment docs.

@dlabrecq dlabrecq force-pushed the dlabrecq:3080-legend-examples branch from cd02142 to 48aea1e Oct 9, 2019
Fixes #3080
@dlabrecq dlabrecq force-pushed the dlabrecq:3080-legend-examples branch from 48aea1e to ac21e8b Oct 9, 2019
@kmcfaul
kmcfaul approved these changes Oct 9, 2019
@redallen redallen merged commit 32f525f into patternfly:master Oct 9, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.