Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): Modifying selection outside now works #3096

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@SpyTec
Copy link
Contributor

SpyTec commented Oct 9, 2019

What: Updating selections should now properly update with typeahead variant

Additional issues: fixes #3095

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 9, 2019

PatternFly-React preview: https://patternfly-react-pr-3096.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #3096 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3096      +/-   ##
==========================================
+ Coverage   69.03%   69.04%   +<.01%     
==========================================
  Files         858      858              
  Lines       23529    23527       -2     
  Branches     1875     1875              
==========================================
  Hits        16244    16244              
+ Misses       6334     6332       -2     
  Partials      951      951
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.14% <0%> (ø) ⬆️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Select/Select.tsx 60.93% <0%> (ø) ⬆️
...y-react-extensions/src/components/Select/Select.js 19.8% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d95763...948e0ca. Read the comment docs.

@tlabaj
tlabaj approved these changes Oct 11, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Oct 11, 2019

@SpyTec We can merge this once conflicts are resolved.

@SpyTec

This comment has been minimized.

Copy link
Contributor Author

SpyTec commented Oct 11, 2019

Conflict fixed :)

@tlabaj tlabaj merged commit bbe99f3 into patternfly:master Oct 11, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 11, 2019

Your changes have been released in:

  • @patternfly/react-charts@5.0.23
  • @patternfly/react-core@3.114.3
  • @patternfly/react-docs@4.14.20
  • @patternfly/react-inline-edit-extension@2.11.88
  • demo-app-ts@3.7.3
  • @patternfly/react-styled-system@3.6.42
  • @patternfly/react-styles@3.5.30
  • @patternfly/react-table@2.23.4
  • @patternfly/react-tokens@2.6.33
  • @patternfly/react-topology@2.8.81
  • @patternfly/react-virtualized-extension@1.2.71
  • @patternfly/react-icons@3.14.10

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.