Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings about use of deprecated lifecycle methods #3098

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@KKoukiou
Copy link
Contributor

KKoukiou commented Oct 9, 2019

The above fixes where done automatically with:
$ npx react-codemod rename-unsafe-lifecycles

Relevant issue: #3170

The above fixes where done automatically with:
$ npx react-codemod rename-unsafe-lifecycles
@KKoukiou KKoukiou force-pushed the KKoukiou:unsafe-lifecycle branch from 7ec61af to 0996696 Oct 9, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #3098 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3098   +/-   ##
=======================================
  Coverage   69.02%   69.02%           
=======================================
  Files         858      858           
  Lines       23432    23432           
  Branches     1859     1859           
=======================================
  Hits        16174    16174           
  Misses       6337     6337           
  Partials      921      921
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <100%> (ø) ⬆️
#patternfly4 68.09% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...fly-react/src/components/Slider/BootstrapSlider.js 53.84% <ø> (ø) ⬆️
...ternfly-3/react-console/src/SerialConsole/XTerm.js 27.41% <ø> (ø) ⬆️
...onents/ToastNotification/TimedToastNotification.js 57.89% <ø> (ø) ⬆️
...rc/components/VerticalNav/VerticalNavItemHelper.js 32.9% <ø> (ø) ⬆️
...rnfly-react/src/components/Pagination/Paginator.js 40.96% <ø> (ø) ⬆️
...ponents/LoginCardComponents/LoginLanguagePicker.js 55.35% <ø> (ø) ⬆️
...nents/ClassificationBanner/ClassificationBanner.js 55.35% <100%> (ø) ⬆️
...ponents/ToastNotification/ToastNotificationList.js 63.79% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f7313d...0996696. Read the comment docs.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 9, 2019

PatternFly-React preview: https://patternfly-react-pr-3098.surge.sh

Copy link
Member

dlabrecq left a comment

I suspect this is fine for PF3, considering it's older code.

Per the React documentation, "These methods are considered legacy and you should avoid them in new code" -- https://reactjs.org/docs/react-component.html

Can you please attach an issue for this?

@tlabaj

This comment has been minimized.

Copy link
Contributor

tlabaj commented Oct 18, 2019

@KKoukiou can you please open an issue for tracking purposes and add it to the description of the PR. Thanks.

@tlabaj
tlabaj approved these changes Oct 21, 2019
Copy link
Contributor

tlabaj left a comment

LGTM

@tlabaj tlabaj merged commit dbff0f1 into patternfly:master Oct 21, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@mturley

This comment has been minimized.

Copy link
Collaborator

mturley commented Nov 4, 2019

This is related to #3010, I didn't realize we also had these methods in our own code (My PR #3249 will pull in the same fixes from react-bootstrap, which should resolve the rest of these warnings for us in PF3). Thanks @KKoukiou !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.