Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aboutmodal,wizard): append component to any element in DOM #3102

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@boaz0
Copy link
Member

boaz0 commented Oct 9, 2019

What:

closes #2917

I added appendTo to both Wizard and AboutModal.

//ping @jschuler can you have a look?

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 9, 2019

PatternFly-React preview: https://patternfly-react-pr-3102.surge.sh

@boaz0 boaz0 force-pushed the boaz0:closes_2917 branch from e77f83a to 8d88d90 Oct 9, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #3102 into master will decrease coverage by 0.08%.
The diff coverage is 62.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3102      +/-   ##
==========================================
- Coverage   69.02%   68.94%   -0.09%     
==========================================
  Files         858      858              
  Lines       23535    23473      -62     
  Branches     1877     1863      -14     
==========================================
- Hits        16246    16184      -62     
- Misses       6336     6366      +30     
+ Partials      953      923      -30
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.22% <ø> (-0.01%) ⬇️
#patternfly4 67.95% <62.85%> (-0.16%) ⬇️
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Wizard/Wizard.tsx 54.12% <56.25%> (+0.28%) ⬆️
...eact-core/src/components/AboutModal/AboutModal.tsx 85.24% <68.42%> (-4.96%) ⬇️
...t-charts/src/components/ChartUtils/chart-legend.ts 10.6% <0%> (-21.72%) ⬇️
...nfly-react/src/components/AboutModal/AboutModal.js 47.11% <0%> (-6.15%) ⬇️
...ternfly-3/react-console/src/SerialConsole/XTerm.js 25% <0%> (-2.42%) ⬇️
...t-charts/src/components/ChartPoint/path-helpers.ts 1.92% <0%> (-1.93%) ⬇️
...ct-charts/src/components/ChartPoint/ChartPoint.tsx 16.66% <0%> (-1.2%) ⬇️
...3/patternfly-react/src/components/Wizard/Wizard.js 33.05% <0%> (-1.06%) ⬇️
...ents/ChartDonutUtilization/ChartDonutThreshold.tsx 73.68% <0%> (-0.97%) ⬇️
...e/src/components/Dropdown/InternalDropdownItem.tsx 72.46% <0%> (-0.78%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dcfb49...f6ea277. Read the comment docs.

@tlabaj tlabaj requested a review from jschuler Oct 10, 2019
@boaz0 boaz0 force-pushed the boaz0:closes_2917 branch from 8d88d90 to cabea3a Oct 11, 2019
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
@boaz0 boaz0 force-pushed the boaz0:closes_2917 branch from cabea3a to f6ea277 Oct 12, 2019
@boaz0

This comment has been minimized.

Copy link
Member Author

boaz0 commented Oct 12, 2019

@dlabrecq - I see the pf4 docs build fails:

WebpackError: ReferenceError: document is not defined

This is because in Gatsby document will be undefined on build

To fix this, I set the appendTo default value to null and in getElement I will return document.body if it's null. Is that OK?

@jschuler jschuler merged commit ec9d5dd into patternfly:master Oct 15, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@boaz0 boaz0 deleted the boaz0:closes_2917 branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.