Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown/Application Launcher/Options Menu): Fix unit tests and options menu #3107

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Oct 10, 2019

Applied Nicole's fix for the Options menu.

Verified that keyhandler is working as expected. Added componentID prop in order to fix failing unit tests on keyhandler due to the id being passed to the <li>.

Fixes #3029.

nicolethoen and others added 2 commits Sep 26, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 10, 2019

PatternFly-React preview: https://patternfly-react-pr-3107.surge.sh

@rebeccaalpert rebeccaalpert changed the title fix(Dropdown/Application Launcher/Options Menu): Fix unit tests fix(Dropdown/Application Launcher/Options Menu): Fix unit tests and options menu Oct 11, 2019
Copy link
Collaborator

mturley left a comment

Looks good to me, thanks @rebeccaalpert !

@dlabrecq dlabrecq merged commit e54f158 into patternfly:master Oct 11, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 11, 2019

Your changes have been released in:

  • @patternfly/react-core@3.115.0
  • @patternfly/react-docs@4.14.22
  • @patternfly/react-inline-edit-extension@2.11.90
  • demo-app-ts@3.7.5
  • @patternfly/react-table@2.23.6
  • @patternfly/react-topology@2.9.0
  • @patternfly/react-virtualized-extension@1.2.73

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.