Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): use props children if custom on filter used #3123

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@karelhala
Copy link
Contributor

karelhala commented Oct 11, 2019

Fixes: #3117

What:
Do not expect filtered values to be returned from onFilter function.

Fix errors when opened Select menu by omiting them from spreaded props.

Additional issues:

@karelhala karelhala requested review from tlabaj, kmcfaul, redallen and jschuler Oct 11, 2019
@karelhala

This comment has been minimized.

Copy link
Contributor Author

karelhala commented Oct 11, 2019

This is rather blocking issue for us, can we look at it with high priority? Thank you.

@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 11, 2019

PatternFly-React preview: https://patternfly-react-pr-3123.surge.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #3123 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3123      +/-   ##
==========================================
- Coverage   69.03%   69.02%   -0.02%     
==========================================
  Files         858      858              
  Lines       23529    23532       +3     
  Branches     1875     1876       +1     
==========================================
- Hits        16244    16242       -2     
- Misses       6334     6337       +3     
- Partials      951      953       +2
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.09% <100%> (-0.04%) ⬇️
Impacted Files Coverage Δ
...-4/react-core/src/components/Select/SelectMenu.tsx 81.66% <100%> (+0.63%) ⬆️
...nfly-4/react-core/src/components/Select/Select.tsx 58.85% <100%> (-2.09%) ⬇️
...y-react-extensions/src/components/Select/Select.js 19.52% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7841c2f...15686e0. Read the comment docs.

Copy link
Member

dlabrecq left a comment

Tested on surge and appears to work fine.

@kmcfaul kmcfaul merged commit b20a624 into patternfly:master Oct 11, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 11, 2019

Your changes have been released in:

  • @patternfly/react-core@3.114.4
  • @patternfly/react-docs@4.14.21
  • @patternfly/react-inline-edit-extension@2.11.89
  • demo-app-ts@3.7.4
  • @patternfly/react-table@2.23.5
  • @patternfly/react-topology@2.8.82
  • @patternfly/react-virtualized-extension@1.2.72

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.