Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Radio): Fix console error #3138

Merged
merged 2 commits into from Oct 15, 2019
Merged

fix(Radio): Fix console error #3138

merged 2 commits into from Oct 15, 2019

Conversation

@tlabaj
Copy link
Contributor

tlabaj commented Oct 14, 2019

#3111

What:

Additional issues:

Titani
@tlabaj tlabaj requested a review from dlabaj Oct 14, 2019
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 14, 2019

PatternFly-React preview: https://patternfly-react-pr-3138.surge.sh

Titani
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #3138 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3138      +/-   ##
==========================================
+ Coverage   69.02%   69.08%   +0.05%     
==========================================
  Files         858      858              
  Lines       23535    23497      -38     
  Branches     1877     1869       -8     
==========================================
- Hits        16246    16233      -13     
+ Misses       6336     6316      -20     
+ Partials      953      948       -5
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.23% <ø> (ø) ⬆️
#patternfly4 68.23% <100%> (+0.12%) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Radio/Radio.tsx 88.88% <100%> (-0.31%) ⬇️
...e/src/components/Dropdown/InternalDropdownItem.tsx 72.46% <0%> (-0.78%) ⬇️
...-4/react-core/src/components/Select/SelectMenu.tsx 81.03% <0%> (-0.64%) ⬇️
...ly-4/react-core/src/components/Tooltip/Tooltip.tsx 84.21% <0%> (-0.28%) ⬇️
...y-react-extensions/src/components/Select/Select.js 19.59% <0%> (-0.12%) ⬇️
...patternfly-react/src/components/Tooltip/Tooltip.js 94.11% <0%> (-0.07%) ⬇️
...mponents/TopologyControlBar/TopologyControlBar.tsx 45.12% <0%> (ø) ⬆️
...nfly-4/react-core/src/components/Select/Select.tsx 63.33% <0%> (+4.47%) ⬆️
...eact-core/src/components/Expandable/Expandable.tsx 87.87% <0%> (+6.92%) ⬆️
...act-core/src/components/Tooltip/TooltipContent.tsx 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e9654...9b44e0f. Read the comment docs.

@dlabaj

This comment has been minimized.

Copy link
Contributor

dlabaj commented Oct 14, 2019

@tlabaj Verified in integr8tly and the error is gone. Thanks.

@dlabaj
dlabaj approved these changes Oct 14, 2019
@tlabaj tlabaj added PF4 and removed Do Not Merge labels Oct 14, 2019
@tlabaj tlabaj requested a review from redallen Oct 14, 2019
@redallen redallen merged commit 3e432b8 into patternfly:master Oct 15, 2019
8 checks passed
8 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_integration Your tests passed on CircleCI!
Details
ci/circleci: build_pf3_docs Your tests passed on CircleCI!
Details
ci/circleci: build_pf4_docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test_jest_other Your tests passed on CircleCI!
Details
ci/circleci: test_jest_pf4 Your tests passed on CircleCI!
Details
ci/circleci: upload_docs Your tests passed on CircleCI!
Details
@patternfly-build

This comment has been minimized.

Copy link
Contributor

patternfly-build commented Oct 15, 2019

Your changes have been released in:

  • @patternfly/react-core@3.116.0
  • @patternfly/react-docs@4.14.26
  • @patternfly/react-inline-edit-extension@2.11.94
  • demo-app-ts@3.7.9
  • @patternfly/react-table@2.23.10
  • @patternfly/react-topology@2.9.4
  • @patternfly/react-virtualized-extension@1.2.77

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.